Allowed tuples to have both named and anonymous members #53356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2dda8ac
to
b7816ea
Compare
JoshuaKGoldberg
commented
Mar 19, 2023
| @@ -6399,7 +6399,7 @@ export interface TupleType extends GenericType { | |||
| hasRestElement: boolean; | |||
| combinedFlags: ElementFlags; | |||
| readonly: boolean; | |||
| labeledElementDeclarations?: readonly (NamedTupleMember | ParameterDeclaration)[]; | |||
| labeledElementDeclarations?: readonly (NamedTupleMember | ParameterDeclaration | undefined)[]; | |||
There was a problem hiding this comment.
[Breaking API Change] Is this the right choice to make? One alternative could be to rename it to elementDeclarations with a type like readonly (ParameterDeclaration | TypeNode). My hunch is that that would be preferable, but I'm going with this smaller change for now to make reviewing easier.
Andarist
reviewed
Mar 19, 2023
jakebailey
reviewed
Mar 23, 2023
Co-authored-by: Jake Bailey <jabaile@microsoft.com>
jakebailey
reviewed
Mar 23, 2023
Co-authored-by: Jake Bailey <jabaile@microsoft.com>
|
I think that it would be nice to get some code coverage for generic mapped types with array constraints. With them named and anonymous elements should be preserved in the same way. Similarly, it should be possible to add new named/anonymous elements using generic conditional types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes #52853
Previously, the
labeledElementDeclarationsproperty onTupleTypes was all-or-nothing for having named vs. anonymous members. Now that it's possible for them to mix-and-match, this PR pulls logic fromgetParameterNameAtPositionintogetTupleElementLabelfor filling in a name (`${restParameterName}_${index}`).