Skip to content

fix(android): Change The android api path reference from 17 to 33.#10209

Merged
NathanWalker merged 4 commits into
NativeScript:mainfrom
KunaalMangal:MK-NativeScript
Feb 21, 2023
Merged

fix(android): Change The android api path reference from 17 to 33.#10209
NathanWalker merged 4 commits into
NativeScript:mainfrom
KunaalMangal:MK-NativeScript

Conversation

@KunaalMangal

Copy link
Copy Markdown
Contributor

Change The android api path reference from 17 to 33 in types-android/src/lib/android.d.ts for accessing latest android api.

image

…ndroid/src/lib/android.d.ts for accessing latest android api.
@nx-cloud

nx-cloud Bot commented Feb 12, 2023

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ca44e4b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@cla-bot

cla-bot Bot commented Feb 12, 2023

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @KunaalMangal.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@rigor789 rigor789 marked this pull request as draft February 13, 2023 10:26
@rigor789

Copy link
Copy Markdown
Member

Marking this as a draft, as I'd like to bring this up on our next TSC Meeting (Technical Steering Committee).

I agree we should change the default API level, however the default should likely be set to API30, and then changed to API31 around Nov 2023 to match the targetSdk requirements (reference: https://apilevels.com/)

Comment thread packages/types-android/src/lib/android.d.ts Outdated
@NathanWalker NathanWalker marked this pull request as ready for review February 16, 2023 15:39
@NathanWalker NathanWalker added this to the 8.5 milestone Feb 16, 2023
Co-authored-by: Nathan Walker <walkerrunpdx@gmail.com>
@cla-bot

cla-bot Bot commented Feb 16, 2023

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @KunaalMangal.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@cla-bot

cla-bot Bot commented Feb 16, 2023

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @KunaalMangal.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

@KunaalMangal

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot cla-bot Bot added the cla: yes label Feb 16, 2023
@cla-bot

cla-bot Bot commented Feb 16, 2023

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@KunaalMangal

Copy link
Copy Markdown
Contributor Author

@cla-bot check

@cla-bot

cla-bot Bot commented Feb 16, 2023

Copy link
Copy Markdown

The cla-bot has been summoned, and re-checked this pull request!

@NathanWalker NathanWalker merged commit e613ecf into NativeScript:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants