New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The github.ref does not contain fully-formed ref of the branch #22727
Comments
|
Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
|
@trivikr Thanks so much for opening an issue! I'll triage this for the team to take a look 👀 |
|
Thanks @cmwilson21 It would be awesome if the bug in As per the documentation, the |
|
@trivikr Thanks for this additional info ✨ Just a heads up, several members of our team are out for the holidays. Someone will have eyes on this soon, until then, we appreciate your patience 💖 |
|
Sure. I'm not blocked, as I used |
|
Hey @trivikr, thank you for opening this! I've reached out to a subject matter expert about this, and will keep you updated with what our next steps will be. 🚀 |
|
Thanks for opening an issue! We've triaged this issue for technical review by a subject matter expert 👀 |
|
Hey @trivikr 👋 After talking with a subject matter expert, we've determined the best way to resolve this would be to update the example code in the doc you linked to use So if we change: to the workflow should do what you want it to do. You can find the supporting documentation for the Thank you for sharing this issue with us, and you or anyone else is welcome to open a PR to apply these changes! 🚀 |
Using Details in Pull Request: awslabs/aws-sdk-js-codemod#362 (comment)
I don't think works as caches are tied to merge branch as per documentation. |
|
Hey @trivikr, I sent your question to our subject matter expert, and they are taking a look to get a better understanding of this. I do see what you are saying about how caches created on pull requests are linked to the merge ref instead of the source branch. I will update you when I have more information! |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as spam.
This comment was marked as spam.
|
Hey @trivikr, I heard back from our subject matter expert and your proposed solution to update:
in the example is a great one. You or anyone else is welcome to pick up this issue and implement that change. 💛 Thank you again for finding this error and working through it with us! |
|
Thanks! I've posted a PR to update cache cleanup example at #23612 |
|
Issue reported once more in: Thanks for working out the fix! |
Code of Conduct
What article on docs.github.com is affected?
https://docs.github.com/en/actions/using-workflows/caching-dependencies-to-speed-up-workflows#force-deleting-cache-entries
What part(s) of the article would you like to see updated?
The workflow run on my GitHub repo indicates that
github.refcontains destination branch when PR is closed, and notrefs/pull/<pr_number>/mergeNote that:
BRANCH=${{ github.ref }}BRANCH=mainEither the documentation needs to be updated to use the following solution instead:
Or the backend code needs to be fixed to provide branch name in
github.refAdditional information
No response
The text was updated successfully, but these errors were encountered: