Skip to content

bpo-43856: Add a versionadded directive to the importlib.metadata docs#25445

Merged
miss-islington merged 1 commit intopython:masterfrom
ZackerySpytz:bpo-43856-importlib-metadata-docs
Apr 16, 2021
Merged

bpo-43856: Add a versionadded directive to the importlib.metadata docs#25445
miss-islington merged 1 commit intopython:masterfrom
ZackerySpytz:bpo-43856-importlib-metadata-docs

Conversation

@ZackerySpytz
Copy link
Copy Markdown
Contributor

@ZackerySpytz ZackerySpytz commented Apr 16, 2021 •
edited by miss-islington
Loading

Use a versionadded directive to generate the text "New in version
3.8." (to match with the documentation of other modules).

https://bugs.python.org/issue43856

Automerge-Triggered-By: GH:jaraco

@ZackerySpytz
bpo-43856: Add a versionadded directive to the importlib.metadata docs
16e65e3 
Use a versionadded directive to generate the text "New in version
3.8." (to match with the documentation of other modules).
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 16, 2021
@shreyanavigyan
Copy link
Copy Markdown
Contributor

shreyanavigyan commented Apr 16, 2021

I think this PR should have a news entry.

@ZackerySpytz
Copy link
Copy Markdown
Contributor Author

ZackerySpytz commented Apr 16, 2021

News entries usually aren't required for minor modifications to the documentation.

@shreyanavigyan
Copy link
Copy Markdown
Contributor

shreyanavigyan commented Apr 16, 2021

Yeah...I agree with you

@miss-islington miss-islington merged commit adf24bd into python:master Apr 16, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 16, 2021

Thanks @ZackerySpytz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 16, 2021

Sorry, @ZackerySpytz, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker adf24bd835ed8f76dcc51aa98c8c54275e86965b 3.9

@miss-islington miss-islington self-assigned this Apr 16, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Apr 16, 2021

Sorry @ZackerySpytz, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker adf24bd835ed8f76dcc51aa98c8c54275e86965b 3.8

jaraco pushed a commit that referenced this pull request Apr 21, 2021
@ZackerySpytz @jaraco
[3.9] bpo-43856: Add a versionadded directive to the importlib.metada…
b66825a 
…ta docs (GH-25445)

Use a versionadded directive to generate the text "New in version
3.8." (to match with the documentation of other modules).

Automerge-Triggered-By: GH:jaraco.
(cherry picked from commit adf24bd)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 21, 2021

GH-25494 is a backport of this pull request to the 3.9 branch.

jaraco pushed a commit that referenced this pull request Apr 21, 2021
@ZackerySpytz @jaraco
[3.8] bpo-43856: Add a versionadded directive to the importlib.metada…
8b0a0be 
…ta docs (GH-25445)

Use a versionadded directive to generate the text "New in version
3.8." (to match with the documentation of other modules).

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit adf24bd)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Apr 21, 2021

GH-25495 is a backport of this pull request to the 3.8 branch.

methane pushed a commit that referenced this pull request Apr 23, 2021
@jaraco @ZackerySpytz
bpo-43856: Add a versionadded directive to the importlib.metadata docs (
d4fff1f 
GH-25445)

Use a versionadded directive to generate the text "New in version
3.8." (to match with the documentation of other modules).

Automerge-Triggered-By: GH:jaraco.
(cherry picked from commit adf24bd)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
methane pushed a commit that referenced this pull request Apr 23, 2021
@jaraco @ZackerySpytz
bpo-43856: Add a versionadded directive to the importlib.metadata docs (
faad2bd 
GH-25445)

Use a versionadded directive to generate the text "New in version
3.8." (to match with the documentation of other modules).

Automerge-Triggered-By: GH:jaraco
(cherry picked from commit adf24bd)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco approved these changes

Assignees

@miss-islington miss-islington

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @shreyanavigyan @miss-islington @bedevere-bot @jaraco @the-knights-who-say-ni