Ruby: At most one hash-splat ParameterNode per callable
#11461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3bb5c5a to
9453bb8
Compare
9453bb8 to
c67262a
Compare
MathiasVP
previously approved these changes
Nov 29, 2022
Contributor
|
Feel free to ignore the Swift CI failures. They should be fixed by merging in the recent |
michaelnebel
previously approved these changes
Nov 29, 2022
Contributor
michaelnebel
left a comment
There was a problem hiding this comment.
C#: Looks plausible to me.
c67262a to
b33f592
Compare
Contributor
Author
|
Rebased to resolve semantic merge conflict (Go data flow libraries now need to be merged as well). |
aibaars
approved these changes
Dec 5, 2022
Contributor
aibaars
left a comment
There was a problem hiding this comment.
Looks good to me. Would it be possible to add a test case for Ruby?
Contributor
Author
Rather, we will be adding some consistency checks to the shared data flow library. |
Contributor
That's even better! |
Contributor
Author
|
Consistency checks: #11564 |
RasmusWL
added a commit
to RasmusWL/codeql
that referenced
this pull request
Jan 27, 2023
Similar to the Ruby changes from github#11461 I feel the change to `DataFlowFunciton.getParameter` where we use `not exists(func.getArgByName(_))` is not very great, but I was not allowed to use `not exists(this.getParameter(any(ParameterPosition _).isKeyword(_)))` because of negative recursion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @aschackmull, it is best to have at most one
ParameterNodeperParameterPositionandDataFlowCallable. This PR ensures that eachDataFlowCallablehas at most oneParameterNodewith hash-splatParameterPosition.