Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test test_asyncio prints quite a few ResourceWarnings for "unclosed event loop" #99357

Closed
gvanrossum opened this issue Nov 10, 2022 · 2 comments
Closed

Test test_asyncio prints quite a few ResourceWarnings for "unclosed event loop" #99357

gvanrossum opened this issue Nov 10, 2022 · 2 comments
Labels
expert-asyncio type-bug An unexpected behavior, bug, or error

Comments

@gvanrossum
Copy link
Member

gvanrossum commented Nov 10, 2022 •
edited by bedevere-bot

It's possible that this only happens when using --with-pydebug. (And perhaps only on Mac?)

I get 8 of these:

/Users/guido/cpython/Lib/asyncio/base_events.py:703: ResourceWarning: unclosed event loop <_UnixSelectorEventLoop running=False closed=False debug=False>
  _warn(f"unclosed event loop {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback

There's also this, once:

/Users/guido/cpython/Lib/test/test_asyncio/test_unix_events.py:1750: DeprecationWarning: 'get_child_watcher' is deprecated as of Python 3.12 and will be removed in Python 3.14.
  watcher = policy.get_child_watcher()
@gvanrossum gvanrossum added type-bug An unexpected behavior, bug, or error expert-asyncio labels Nov 10, 2022
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Nov 11, 2022

I'll take care of the last one in #99386

xiaochen7 added a commit to xiaochen7/cpython that referenced this issue Nov 12, 2022
@xiaochen7
pythongh-99357: Close the event loop when it is no longer used in tes…
aaef027 
…t_uncancel_structured_blocks
@bedevere-bot bedevere-bot mentioned this issue Nov 12, 2022
Merged
@xiaochen7
Copy link
Contributor

xiaochen7 commented Nov 12, 2022

Closing event loop was missed in test_uncancel_structured_blocks, I submitted a PR #99414 to fix this : )

gvanrossum pushed a commit that referenced this issue Nov 12, 2022
@xiaochen7
gh-99357: Close the event loop when it is no longer used in test_unca…
99972dc 
…ncel_structured_blocks (#99414)
@bedevere-bot bedevere-bot mentioned this issue Nov 13, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 13, 2022
@xiaochen7 @miss-islington
pythongh-99357: Close the event loop when it is no longer used in tes…
29f11df 
…t_uncancel_structured_blocks (pythonGH-99414)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <chenxiao_7@163.com>
gvanrossum pushed a commit that referenced this issue Nov 14, 2022
@miss-islington @xiaochen7
[3.11] gh-99357: Close the event loop when it is no longer used in te…
90de4b7 
…st_uncancel_structured_blocks (GH-99414) (#99424)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <chenxiao_7@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
expert-asyncio type-bug An unexpected behavior, bug, or error
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvanrossum @xiaochen7 @kumaraditya303