Swift: refactor visitors to use translations #11094
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatternVisitor to use translationsed84002
to
1459459
Compare
Also make `visit` in `SwiftDispatcher` work on `const` pointers. Also, fixed a bug where the guard of a `CaseLabelItem` was not being extracted, hence the test updates.
28398ec
to
e0eb820
Compare
AlexDenisov
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This refactors all visitors to use translation style implementations with structured C++ classes (as opposed to visit and explicit traps). This was required as a preparation step for further work on making the extractor reliable against incomplete ASTs.
Also most explicit asserts have been removed, as they became obsolete with the assert in
fetchLabel.In the process of this there was
CaseLabelItemwas not being extractedlist[...]tolist[optional[...]]that were required with the structured C++ classesCommit by commit review is strongly encouraged.