Swift: Unsafe JS Eval Query #11001
Draft
Swift: Unsafe JS Eval Query #11001
+132
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow clangd to use the generated `swift/compile_commands.json` for intellisense in the codeql repository, via `.vscode/settings.json`. The `-arch=x86_64` from `swift/rules.bzl` turns out to be unnecessary, even on Arm-based Macs.
geoffw0
reviewed
Oct 31, 2022
| "--header-insertion=never", | ||
| "--compile-commands-dir=${workspaceFolder}/swift", | ||
| "--query-driver=**" | ||
| ] |
There was a problem hiding this comment.
I'm not all that familiar with this stuff (the first commit of this PR).
|
|
||
| /** | ||
| * A source of untrusted, user-controlled data. | ||
| * TODO: Extend to more (non-remote) sources in the future. |
There was a problem hiding this comment.
Yep, I think this is a good example of a query where I would be nervous even of local user input being evaluated.
There was a problem hiding this comment.
I've created github/codeql-c-team#1318 to address this as follow-up.
| ce.getStaticTarget() = getFunctionWithQualifiedName("JSEvaluateScript(_:_:_:_:_:_:)") | ||
| ).getArgument(1).getExpr() = this.asExpr() | ||
| } | ||
| } |
There was a problem hiding this comment.
Great coverage with all of these sinks!
| // - parentDecl = memberDecl.getDeclaringDecl() <=> parentDecl.getAMember() = memberDecl | ||
| IterableDeclContext getDeclaringDeclOf(Decl member) { result.getAMember() = member } | ||
|
|
||
| MethodDecl getMethodWithQualifiedName(string className, string methodName) { |
There was a problem hiding this comment.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.