Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "SSA: Turn consistency predicates into query predicates" #11074

Merged
merged 1 commit into from Nov 2, 2022
Merged

Revert "SSA: Turn consistency predicates into query predicates" #11074

merged 1 commit into from Nov 2, 2022
+28 −16

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 2, 2022

Reverts #10576

@hvitved hvitved requested review from a team as code owners Nov 2, 2022
@michaelnebel
Copy link
Contributor

michaelnebel commented Nov 2, 2022

What went wrong?

michaelnebel
michaelnebel approved these changes Nov 2, 2022
View changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

LGTM

@hvitved
Copy link
Contributor Author

hvitved commented Nov 2, 2022

What went wrong?

The PR uses QL language features that are not yet released, so we will have to wait a bit.

@hvitved hvitved merged commit f603d96 into main Nov 2, 2022
21 of 22 checks passed
@hvitved hvitved deleted the revert-10576-ssa/consistency-queries branch Nov 2, 2022
@hvitved hvitved mentioned this pull request Nov 2, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel

@github/codeql-ruby codeql-ruby

Assignees
No one assigned
Labels
C# Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hvitved @michaelnebel