Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS: push more context into load/store steps from the exploratory flow-analysis #10986

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Oct 26, 2022

Saves an additional 15s (out of ~6 minutes) when running the code-scanning suite on the database from #10937

Evaluation looks somewhat uneventful.
I'm pretty sure the cache size is just noise.

@github-actions github-actions bot added the JS label Oct 26, 2022
@erik-krogh erik-krogh marked this pull request as ready for review Oct 26, 2022
@erik-krogh erik-krogh requested a review from a team as a code owner Oct 26, 2022
@esbena
Copy link
Contributor

esbena commented Oct 26, 2022

When the cache size is reported to be exactly '1.032' (as it is here), we suspect an unknown cache cleanup step to have happened. This has happened ~3 times in a few months.

@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Oct 26, 2022
@calumgrant calumgrant requested a review from asgerf Oct 31, 2022
Labels
JS no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants