Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data flow: Restrict public PathNodes to those that may reach a sink #11060

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Data flow: Restrict public PathNodes to those that may reach a sink #11060

wants to merge 4 commits into from
+2,946 −2,765

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 1, 2022 •
edited

Just like PathNode::getASuccessor is restricted to nodes that can reach a sink, it also makes sense to only expose nodes that can reach a sink. This means that the exposed PathNode class and the nodes predicate contain the same elements.

The reason for the updated C++ test output is because DefaultTaintTracking.qll did not previously restrict the nodes relation to nodes that can reach a sink.

@hvitved hvitved force-pushed the dataflow/path-node-reach-charpred branch from 315e92f to 2198eaa Compare Nov 1, 2022
@hvitved hvitved added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Nov 1, 2022
@hvitved hvitved mentioned this pull request Nov 1, 2022
Draft
29 tasks
@hvitved hvitved force-pushed the dataflow/path-node-reach-charpred branch from 2198eaa to edbf7e5 Compare Nov 1, 2022
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 1, 2022
@hvitved hvitved marked this pull request as ready for review Nov 1, 2022
@hvitved hvitved requested review from a team as code owners Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-c codeql-c

@github/codeql-ruby codeql-ruby

@github/codeql-python codeql-python

@github/codeql-java codeql-java

@github/codeql-csharp codeql-csharp

@github/codeql-c-analysis codeql-c-analysis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C# C++ DataFlow Library depends on internal PR This PR should only be merged in sync with an internal Semmle PR Java no-change-note-required This PR does not need a change note Python Ruby Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@hvitved