Ruby: Model various ActionController methods #11058

hmac · 2022-10-31T23:38:27Z

ActionController methods have access to a logger method which returns an instance of ActiveSupport::Logger.

The first commit moves the existing ActionController.ql test to be inside the action_controller directory, so that is no longer affected by changes to other test fixtures. I think we should probably do this for the remaining tests (ActionDispatch, ActionView, Core, GraphQL, PosixSpawn) at some point.

Later commits model send_data and body_stream.

This test shows that we correctly identify redirect_to and render calls inside respond_to blocks.

hmac added 2 commits Oct 31, 2022

Ruby: Move ActionController tests to own directory

1d95ad9

Ruby: Model ActionController logger

4bea04b

github-actions bot added QL-for-QL Ruby labels Oct 31, 2022

hmac force-pushed the actioncontroller-logger branch from 9f29317 to 4bea04b Compare Oct 31, 2022

hmac removed the QL-for-QL label Oct 31, 2022

hmac added 3 commits Oct 31, 2022

Ruby: Add test for render calls

d541384

Ruby: Test render inside redirect_to

a3c6bc6

This test shows that we correctly identify redirect_to and render calls inside respond_to blocks.

Ruby: Model send_data as an HTTP response

9abd9cb

hmac changed the title ~~Ruby: ActionController logger~~ Ruby: Model various ActionController methods Nov 1, 2022

hmac added 3 commits Nov 1, 2022

Ruby: Model ActionDispatch::Request#body_stream

66872cf

Ruby: Update tests

742972f

Ruby: Add change note

3c0a393

github-actions bot added the documentation label Nov 1, 2022

Ruby: Model various ActionController methods #11058

Are you sure you want to change the base?

Ruby: Model various ActionController methods #11058

Conversation

hmac commented Oct 31, 2022 • edited

hmac commented Oct 31, 2022 •

edited