Swift: Add field flow#10157
Merged
Merged
Conversation
594a1b5 to
80bf22c
Compare
…tion information.
AlexDenisov
approved these changes
Aug 31, 2022
Contributor
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Part of https://github.com/github/codeql-c-team/issues/903.)
This is the final PR needed for adding field flow for Swift. We replace the old
TInOutUpdateNodewith an IPA branch for post-update nodes, and include the various things that need post-update nodes (arguments to functions, and base expressions for field lookups and stores). Then we can pretty much steal Ruby'sreadStepandstoreStepfor fields 🎉.The PR also implements
clearsContentusing the trivial implementation that depends on use-use flow.