Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some "truthy/falsy" crept in #95454

Closed
pochmann opened this issue Jul 29, 2022 · 5 comments
Closed

Some "truthy/falsy" crept in #95454

pochmann opened this issue Jul 29, 2022 · 5 comments
Labels
docs Documentation in the Doc dir

Comments

@pochmann
Copy link
Contributor

pochmann commented Jul 29, 2022

Python consistently says true/false, not truthy/falsy. But a few "truthy/falsy" crept into the logging docs:

https://github.com/python/cpython/search?q=truthy
https://github.com/python/cpython/search?q=falsy

(Previous issue about a previous instance)
@pochmann pochmann added the docs Documentation in the Doc dir label Jul 29, 2022
PurityLake added a commit to PurityLake/cpython that referenced this issue Jul 30, 2022
@PurityLake
pythongh-95454: Replaced truthy/falsy with true/false
a5440bd
PurityLake added a commit to PurityLake/cpython that referenced this issue Jul 30, 2022
@PurityLake
pythongh-95454: Remove truthy with true
43b4be4
@PurityLake PurityLake mentioned this issue Jul 30, 2022
Merged
PurityLake added a commit to PurityLake/cpython that referenced this issue Jul 30, 2022
@PurityLake
pythongh-95454: change NEWS doc
1f37d2f
rhettinger pushed a commit that referenced this issue Jul 30, 2022
@PurityLake
gh-95454: Replace truthy/falsy with true/false (GH-95456)
cd26595
@PurityLake
Copy link
Contributor

PurityLake commented Jul 30, 2022

This can probably be closed now unless I missed some.

@pochmann
Copy link
Contributor Author

pochmann commented Jul 30, 2022 •
edited

@PurityLake The above search for falsy still finds a few in Lib/test/test_except_star.py (not sure if intentional ... in the previous issue, rhettinger also left some in test code and only fixed the docs (which is why above I only spoke of the docs), but it looks like you tried to fix truly all).

@PurityLake
Copy link
Contributor

PurityLake commented Jul 30, 2022

@pochmann maybe I was a little over zealous, hasn't seemed to affect the functionality at least, I'll make another PR to squash that last one. Seemed Raymond was the one to commit the changes so he must not have minded.

@rhettinger
Copy link
Contributor

rhettinger commented Jul 30, 2022

IMO the PR was too aggressive. I approved it only because it wasn't worth the time to debate each individual case. Let's be done with this one now.

@PurityLake
Copy link
Contributor

PurityLake commented Jul 30, 2022

Apologies, I'll be more diligent in future

@erlend-aasland erlend-aasland closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pochmann @rhettinger @PurityLake @erlend-aasland