gh-65169: Clarify prog behavior in argparse - #31602
Conversation
DanielNoord
left a comment
There was a problem hiding this comment.
We should probably add the co-author in the commit message so they actually get credited for it.
Also, we can now link to the github issue so it gets closed when this gets merged.
|
I believe that on merge, Github will automatically pull the co-author from the description so no need to put it in the commit message. Good point on the gh issue, I'll change them over for convenience. |
|
@DanielNoord I have created a new PR #96983. I also mentioned both @slateny and @lilbludot on that. |
|
What's the reason for making a new PR? |
|
@asvetlov It looks like the section being updated here was written by you some 10 years ago, could you take a peek at it? |
savannahostrowski
left a comment
There was a problem hiding this comment.
It looks like this may have gotten lost in the fold but after reading through the issue thread, this looks good to me.
|
Thanks @slateny for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
(cherry picked from commit e69ff34) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
|
GH-124430 is a backport of this pull request to the 3.13 branch. |
(cherry picked from commit e69ff34) Co-authored-by: Stanley <46876382+slateny@users.noreply.github.com>
|
GH-124431 is a backport of this pull request to the 3.12 branch. |
For the latter part of the PR, my understanding is that we have this originally:
which implies that if the program is called like
then the help message will match it, but that's inaccurate. And while symlinks were mentioned in the bpo I'm not too sure how the original would read wrong, but nonetheless the suggested rewording fits well to me so I've used it with some very minor changes.
Co-authored-by: Kinga Farkas
https://bugs.python.org/issue20970