Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ability to bypass environment variable authorization #5839

Open
wants to merge 6 commits into
base: trunk
Choose a base branch
from

Conversation

eeternalspring
Copy link

@eeternalspring eeternalspring commented Jun 22, 2022

Fixes #3799

  • Adds a -f, --force-auth flag that allows user to bypass environment variable authorization (e.g. authorization using GH_TOKEN)
  • Adds support for override_env flag in /path/to/hosts.yml, that bypasses environment variable authorization, automatically set when gh auth login -fing

TODO

  • see which tests fail, fix those, see if any new tests are needed

eeternalspring and others added 6 commits Jun 21, 2022
- if there exists a /path/to/config/hosts.yml use that instead of
  env

TODO
- have new flag set a var in /path/to/config/config.yml that
  drives overriding env, instead of defacto overriding env
- adds `-f` flag to force authing through config file over environment variables
  - updates config and sets `override_env = true`, so that subsequent calls know to use config over env
@eeternalspring eeternalspring requested a review from as a code owner Jun 22, 2022
@eeternalspring eeternalspring requested review from mislav (assigned from cli/code-reviewers) and removed request for Jun 22, 2022
@cliAutomation cliAutomation added the external label Jun 22, 2022
@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external
Projects
The GitHub CLI
  
Needs review 🤔
Development

Successfully merging this pull request may close these issues.

2 participants