Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This pull request adds support for json output the to gh pr checks #4671

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

areese
Copy link

@areese areese commented Nov 3, 2021

…command.

It also adds support for a json format of * which is translated to all known fields.
Support for '*' json format affects all commands with a --json flag.

Add support for the --json and --jq flags to gh pr checks
Add support for '*' to be passed as fields for the --json flag to allow all fields to be returned

Fixes: #4671

@areese areese requested a review from as a code owner Nov 3, 2021
@areese areese requested review from vilmibm (assigned from cli/code-reviewers) and removed request for Nov 3, 2021
@cliAutomation
Copy link
Collaborator

@cliAutomation cliAutomation commented Nov 3, 2021

Hi! Thanks for the pull request. Please ensure that this change is linked to an issue by mentioning an issue number in the description of the pull request. If this pull request would close the issue, please put the word 'Fixes' before the issue number somewhere in the pull request body. If this is a tiny change like fixing a typo, feel free to ignore this message.

@cliAutomation cliAutomation added this to Needs review 🤔 in The GitHub CLI Nov 3, 2021
This pull request adds support for json output the to `gh pr checks` command.
It also adds support for a json format of `*` which is translated to all known fields.
Support for '*' json format affects all commands with a --json flag.

Add support for the --json and --jq flags to `gh pr checks`
Add support for '*' to be passed as fields for the --json flag to allow all fields to be returned
@areese areese force-pushed the add-json-output-to-pr-checks branch from f2315da to 4f284b3 Compare Nov 3, 2021
Cleanup the code for generating the json, separate json printing and table printing into 2 separate functions.
Create a summary structure that can be used for collecting the passing/failing/skipping/pending data.
Move summary generation into a function that operates on the summary structure.

Add passing/failing/skipping/pending to the top level json output
@darcyclarke darcyclarke added the needs-design label Nov 17, 2021
@mislav mislav added the external label Dec 20, 2021
@samcoe samcoe removed the needs-design label Apr 7, 2022
@Valenteguardado

This comment was marked as spam.

@samcoe samcoe removed the request for review from vilmibm Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external
Projects
The GitHub CLI
  
Needs review 🤔
Development

Successfully merging this pull request may close these issues.

None yet

6 participants