feat: Added method topmost in RootLayout. #9826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see there are no tests for RootLayout and it's a different case since it usually works only if it's rendered as a root-level view. |
|
Very handy @DimitrisRK thank you |
NathanWalker
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
PR Checklist
What is the current behavior?
Developers have no way to get topmost view of rootlayout.
What is the new behavior?
Developers can use method
topmostto get topmost view of rootlayout.I found this quite useful when I needed to handle view closing during android backpressed event.
This method will simply return the view of the last item in
popupViewsarray which is not accessible in TypeScript.