New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-91752: Skip test_freeze_simple_script when zlib is not available #91758
Conversation
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
You don't have to import the function, just it from support module directly.
|
Is there anything else I need to do here ? |
Looks like this simply fell between the cracks. Since @tiran approved it I am just going to merge it for you.
|
Are backports needed? |
|
Let's try 3.10, 3.9. |
|
Thanks @AbhigyanBose for the PR, and @gvanrossum for merging it |
|
Thanks @AbhigyanBose for the PR, and @gvanrossum for merging it |
|
Sorry, @AbhigyanBose and @gvanrossum, I could not cleanly backport this to |
|
Sorry @AbhigyanBose and @gvanrossum, I had trouble checking out the |
|
I don't care enough about the backports, I'll remove the labels. @AbhigyanBose If you want to see if manually backporting makes sense, go ahead, but don't spend much time on it (the likely cause of the failure is that the code doesn't exist in that form in 3.10 or 3.9). Start with 3.10 first, if any. |
|
I'm testing if backport's needed right now. But this issue seems to occur only for fresh installs of the OS (some dependency for a different application resolved the missing module issue on my daily os, currently testing with Docker containers) |
|
Checked both 3.10 and 3.9, no backports required. |
|
Cheers! Thanks for checking. |
gh-91752: Skip test_freeze_simple_script when zlib is not available