Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-91752: Skip test_freeze_simple_script when zlib is not available #91758

Merged
merged 3 commits into from May 3, 2022

Conversation

AbhigyanBose
Copy link
Contributor

@AbhigyanBose AbhigyanBose commented Apr 20, 2022

gh-91752: Skip test_freeze_simple_script when zlib is not available

@cpython-cla-bot
Copy link

@cpython-cla-bot cpython-cla-bot bot commented Apr 20, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 20, 2022

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 22, 2022

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@tiran tiran changed the title Added @requires_zlib to test_freeze_simple_script.(GH-91752) GH-91752: Skip test_freeze_simple_script when zlib is not available Apr 22, 2022
Copy link
Member

@tiran tiran left a comment

Please move the blurb from Library to Tests category.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 22, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

Copy link
Member

@tiran tiran left a comment

You don't have to import the function, just it from support module directly.

Lib/test/test_tools/test_freeze.py Outdated Show resolved Hide resolved
Lib/test/test_tools/test_freeze.py Outdated Show resolved Hide resolved
tiran
tiran approved these changes Apr 22, 2022
Copy link
Member

@tiran tiran left a comment

LGTM, thanks for the quick fix!

@AbhigyanBose
Copy link
Contributor Author

@AbhigyanBose AbhigyanBose commented Apr 24, 2022

@tiran

Is there anything else I need to do here ?
Or should I just wait for someone to merge this ?

Copy link
Member

@gvanrossum gvanrossum left a comment

Looks like this simply fell between the cracks. Since @tiran approved it I am just going to merge it for you.

@gvanrossum gvanrossum merged commit 77e7a04 into python:main May 3, 2022
13 checks passed
@merwok
Copy link
Member

@merwok merwok commented May 3, 2022

Are backports needed?

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented May 3, 2022

Let's try 3.10, 3.9.

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 3, 2022

Thanks @AbhigyanBose for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 3, 2022

Thanks @AbhigyanBose for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 3, 2022

Sorry, @AbhigyanBose and @gvanrossum, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 77e7a04cd235f1bcd6fc69bcb15e2683c365d637 3.9

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 3, 2022

Sorry @AbhigyanBose and @gvanrossum, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 77e7a04cd235f1bcd6fc69bcb15e2683c365d637 3.10

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented May 3, 2022

I don't care enough about the backports, I'll remove the labels. @AbhigyanBose If you want to see if manually backporting makes sense, go ahead, but don't spend much time on it (the likely cause of the failure is that the code doesn't exist in that form in 3.10 or 3.9). Start with 3.10 first, if any.

@AbhigyanBose
Copy link
Contributor Author

@AbhigyanBose AbhigyanBose commented May 3, 2022

I'm testing if backport's needed right now. But this issue seems to occur only for fresh installs of the OS (some dependency for a different application resolved the missing module issue on my daily os, currently testing with Docker containers)

@AbhigyanBose
Copy link
Contributor Author

@AbhigyanBose AbhigyanBose commented May 3, 2022

Checked both 3.10 and 3.9, no backports required.

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented May 3, 2022

Cheers! Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants