Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-87624: Add tutorial example for scope in blocks #91652

Closed
wants to merge 3 commits into from

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Apr 18, 2022

@bedevere-bot bedevere-bot added docs awaiting review labels Apr 18, 2022
@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 30, 2022

I'm not sure any change is needed here. The tutorial should be kept concise, and there is already wording a few paragraphs up saying that the scope belongs to the function, not a try or if block.

@rhettinger
Copy link
Contributor

@rhettinger rhettinger commented Apr 30, 2022

I concur with Jelle.

@slateny
Copy link
Contributor Author

@slateny slateny commented May 1, 2022

Having already known that scope belong to functions (and maybe classes?), the tutorial seems clear and concise, but if I did come from a other language, I think without an explicit statement there is room for confusion.

I agree that it's best not too make the tutorial too bloated so I have no problems with dropping the example, but I still feel just a brief sentence on, say, an if statement would help quite a bit with hammering the point home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants