fix(android): prevent “flashing” activity on app start#9190
Merged
Conversation
This was due to a change made a while back to fix an issue with resetRootView. The consequence was that we were waiting for the frame to be “attachedToWindow” to load the first frame page. That PR make it so that we apply that check/fix only when the activity was reset. Thus it wont happen on app start
Member
|
We need to make sure the are no cases where |
NathanWalker
approved these changes
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was due to a change made a while back to fix an issue with resetRootView.
The consequence was that we were waiting for the frame to be “attachedToWindow” to load the first frame page.
That PR make it so that we apply that check/fix only when the activity was reset. Thus it wont happen on app start
The flash issue is currently seeable on ALL apps. Though it depends on the complexity of the first frame page. the more complex the longer you lll see the "white" screen issue (white being your activity background color)