simplify expressions that could be type-casts #7668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
approved these changes
Jan 20, 2022
esbena
approved these changes
Jan 20, 2022
yoff
reviewed
Jan 20, 2022
Comment on lines
39
to
-42
| exists(DataFlow::Node r | r = requestNode.getAMethodCall("body") | result = r) | ||
| or | ||
| // Otherwise, treat the response as the response body. | ||
| not exists(DataFlow::Node r | r = requestNode.getAMethodCall("body")) and |
Contributor
There was a problem hiding this comment.
I wonder if the line
exists(DataFlow::Node r | r = requestNode.getAMethodCall("body") | result = r)
could also be simplified to
result = requestNode.getAMethodCall("body")
if the query was extended slightly? (We know that result has type DataFlow::Node in this case.)
Contributor
Author
There was a problem hiding this comment.
It could, and originally my query did just that (see the discussion in the PR).
But that had too many FPs, so I dropped it.
MathiasVP
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issues identified by this QL-for-QL query.
Consider the below:
That is basically just a type-cast, so we might as well simplify it as such:
There are also some cases where the resulting type-cast would be redundant.
Here's an example:
The
getAttributepredicate hasXMLAttributeas its result type, so adding a type-cast would be redundant.It is therefore simplified as follows:
The patch was generated automatically by a tool.
(GitHub people: you can see how in the backref below).