repl: make autocomplete case-insensitive #41632
Merged
+138
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ad59a7
to
205e938
Compare
|
Welcome, @gribnoysup, and thank you for the pull request! Can you please update the subsystem in the commit message to be |
205e938
to
5c98227
Compare
|
Hi @Trott |
22 tasks
addaleax
approved these changes
Jan 24, 2022
Trott
approved these changes
Jan 24, 2022
28 tasks
targos
reviewed
Jan 25, 2022
26 tasks
30 tasks
22 tasks
jasnell
approved these changes
Jan 28, 2022
22 tasks
|
Hey it looks like this has some conflicts, would you mind rebasing on top of master? |
5b0a5ef
to
f1eaa85
Compare
aduh95
reviewed
Jun 5, 2022
bb6f57b
to
3e7e3df
Compare
aduh95
approved these changes
Jun 5, 2022
This changes autocomplete suggestion filter to ignore input case allowing for more autosuggest results shown on the screen Fixes: nodejs#41631
3e7e3df
to
fea6adf
Compare
|
@benjamingr #41632 (comment) is resolved now if you want to take another look and proceed with this one. I'm not sure I understand the process exactly, but I'm guessing this needs |
|
Landed in 156365e |
italojs
pushed a commit
to italojs/node
that referenced
this issue
Jun 12, 2022
This changes autocomplete suggestion filter to ignore input case allowing for more autosuggest results shown on the screen Fixes: nodejs#41631 PR-URL: nodejs#41632 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
pushed a commit
that referenced
this issue
Jun 13, 2022
This changes autocomplete suggestion filter to ignore input case allowing for more autosuggest results shown on the screen Fixes: #41631 PR-URL: #41632 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
15 tasks
danielleadams
pushed a commit
that referenced
this issue
Jun 13, 2022
This changes autocomplete suggestion filter to ignore input case allowing for more autosuggest results shown on the screen Fixes: #41631 PR-URL: #41632 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This changes autocomplete suggestion filter to ignore input case
when first character of the last member of the user input is lower-case
allowing for more autosuggest results shown on the screen
Fixes: #41631