Experiment with a fixed threshold#7512
Closed
tiferet wants to merge 4 commits into
Closed
Conversation
Contributor
Author
|
/evaluate NosqlInjection |
Contributor
Author
|
/evaluate SqlInjection |
Contributor
Author
|
/evaluate TaintedPath |
Contributor
Author
|
/evaluate Xss |
Contributor
Author
|
The above experiments use a cutoff of 0.65 on the model that's on |
Make sure we get near-perfect recall (ATM-light) and bad precision.
Contributor
Author
|
Replaced by #7519 because I need to update the worse rather than current libraries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After all the changes made on the modeling side, there is now better separation in scores between TPs and FPs.
This PR experiments with setting a hard-coded score threshold > 0.5 to determine which alerts to surface, rather than always selecting the max-likelihood class, thereby reducing FPs.
Replaced by #7519 because I need to update the worse rather than current libraries.