Skip to content

bpo-46245: Add optional parameter dir_fd in shutil.rmtree()#30365

Merged
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:rmtree-dir_fd
Mar 9, 2022
Merged

bpo-46245: Add optional parameter dir_fd in shutil.rmtree()#30365
serhiy-storchaka merged 3 commits into
python:mainfrom
serhiy-storchaka:rmtree-dir_fd

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jan 3, 2022

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka changed the title po-46245: Add optional parameter dir_fd in shutil.rmtree() bpo-46245: Add optional parameter dir_fd in shutil.rmtree() Jan 4, 2022
Comment thread Lib/shutil.py Outdated
Comment on lines +686 to +689
If dir_fd is not None, it should be a file descriptor open to a directory,
and path should be relative; path will then be relative to that directory.
dir_fd may not be implemented on your platform.
If it is unavailable, using it will raise a NotImplementedError.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was copied from the docstring for os.rmdir(), but I don't like it. I'll change wording for os.rmdir() and others in separate issue.

@github-actions

github-actions Bot commented Feb 4, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PR or inactive for long period of time. type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants