Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): prevent error when detaching from unloaded ScrollView #9666

Merged
merged 2 commits into from Jan 23, 2022

Conversation

edusperoni
Copy link
Contributor

@edusperoni edusperoni commented Nov 12, 2021

PR Checklist

What is the current behavior?

when calling .off in specific situations, the native view is null, even though isLoaded is true, so an error occurs

What is the new behavior?

error no longer occurs

Still need some investigation as to why isLoaded is true and native view is null

@cla-bot cla-bot bot added the cla: yes label Nov 12, 2021
@NathanWalker NathanWalker added this to the 8.2 milestone Dec 23, 2021
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 Jan 23, 2022
@NathanWalker NathanWalker merged commit 492bba3 into release/8.2.0 Jan 23, 2022
2 of 3 checks passed
@NathanWalker NathanWalker deleted the fix/scroll-view-detach-guard branch Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants