Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: tab view android icon rendering mode #9605

Merged
merged 4 commits into from Feb 17, 2022
Merged

feat: tab view android icon rendering mode #9605

merged 4 commits into from Feb 17, 2022

Conversation

wSedlacek
Copy link
Contributor

@wSedlacek wSedlacek commented Oct 9, 2021 •
edited

PR Checklist

What is the current behavior?

On Android, the TabView always renders icons without any tinting.
This is similar to the alwaysOriginal option of the iosIconRenderingMode on iOS

What is the new behavior?

There is a new option, androidIconRenderingMode which provides alwaysOriginal (default) and alwaysTemplate options.
These options behave similar to iOS, however the default on Android is alwaysOriginal where as iOS defaults to automatic which prefers templates.

Screen.Recording.2021-10-09.at.8.42.01.AM.mov

@cla-bot cla-bot bot added the cla: yes label Oct 9, 2021
@wSedlacek
Copy link
Contributor Author

@wSedlacek wSedlacek commented Oct 9, 2021

@triniwiz Could you give this a review when you get a chance?

@wSedlacek wSedlacek force-pushed the feat/tab-view-android-icon-rendering-mode branch from ec4d9cf to 1900995 Compare Oct 9, 2021
@triniwiz
Copy link
Member

@triniwiz triniwiz commented Oct 9, 2021

LGTM ... thinking this should go into .2 , what you think @NathanWalker @rigor789 👀

@NathanWalker
Copy link
Contributor

@NathanWalker NathanWalker commented Oct 9, 2021

Great work @wSedlacek thank you - Yes we'll queue this one for 8.2.

@NathanWalker NathanWalker added this to the 8.2 milestone Oct 9, 2021
@rigor789 rigor789 marked this pull request as draft Oct 9, 2021
@rigor789
Copy link
Member

@rigor789 rigor789 commented Oct 9, 2021

Awesome! I converted to draft so we don't accidentally merge it before we start merging 8.2 stuff.

@NathanWalker NathanWalker marked this pull request as ready for review Feb 17, 2022
@NathanWalker NathanWalker changed the base branch from master to release/8.2.0 Feb 17, 2022
@NathanWalker NathanWalker force-pushed the feat/tab-view-android-icon-rendering-mode branch from 387dc26 to 1fcf5db Compare Feb 17, 2022
@cla-bot
Copy link

@cla-bot cla-bot bot commented Feb 17, 2022

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: wSedlacek.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla: yes label Feb 17, 2022
@NathanWalker NathanWalker merged commit 874b872 into NativeScript:release/8.2.0 Feb 17, 2022
1 of 3 checks passed
NathanWalker pushed a commit that referenced this issue Feb 18, 2022
@wSedlacek @NathanWalker
feat(android): tab view icon rendering mode (#9605)
a1882d7 
Co-authored-by: wSedlacek <wsedlacekc@gmail.com>
NathanWalker pushed a commit that referenced this issue Mar 1, 2022
@wSedlacek @NathanWalker
feat(android): tab view icon rendering mode (#9605)
66d8aff 
Co-authored-by: wSedlacek <wsedlacekc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanWalker NathanWalker

Assignees
No one assigned
Labels
hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wSedlacek @triniwiz @NathanWalker @rigor789