Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-45162: Remove many old deprecated unittest features #28268

Merged
merged 5 commits into from Sep 17, 2021
Merged

bpo-45162: Remove many old deprecated unittest features #28268

merged 5 commits into from Sep 17, 2021

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Sep 10, 2021 •
edited by bedevere-bot

  • "fail*" and "assert*" aliases of TestCase methods.
  • Broken from start TestCase method assertDictContainsSubset().
  • Ignored TestLoader.loadTestsFromModule() parameter use_load_tests.
  • Old alias _TextTestResult of TextTestResult.

https://bugs.python.org/issue45162
@serhiy-storchaka
bpo-45162: Remove many old deprecated unittest features
4062f07 
* "fail*" and "assert*" aliases of TestCase methods.
* Broken from start TestCase method assertDictContainsSubset().
* Ignored TestLoader.loadTestsFromModule() parameter use_load_tests.
* Old alias _TextTestResult of TextTestResult.
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 10, 2021

🤖 New build scheduled with the buildbot fleet by @ambv for commit 2d96fb9 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@ambv ambv self-requested a review Sep 12, 2021
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 12, 2021

See also GH-20400. Should I reopen?

@serhiy-storchaka
Copy link
Member Author

@serhiy-storchaka serhiy-storchaka commented Sep 12, 2021

I do not know why GH-20400 was closed. Seems there were no objections against it.

But many of these functions are still used in Python tests, so we should first clean up tests from them. Also, we need to research how often they are used in third-party code. The deprecation period can be prolonged if there are many occurrences. All features removed in this PR were deprecated for at least 6 releases.

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Sep 12, 2021

I do not know why GH-20400 was closed. Seems there were no objections against it.

I closed it because I got no response, and I had enough to do already with my sqlite3 PR's :)

Also, we need to research how often they are used in third-party code. The deprecation period can be prolonged if there are many occurrences. All features removed in this PR were deprecated for at least 6 releases.

Absolutely.

@serhiy-storchaka serhiy-storchaka merged commit b0a6ede into python:main Sep 17, 2021
12 checks passed
@serhiy-storchaka serhiy-storchaka deleted the unittest-remove-deprecated branch Sep 17, 2021
@tirkarthi tirkarthi mentioned this pull request Oct 4, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 4, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 4, 2021
Closed
@tirkarthi tirkarthi mentioned this pull request Oct 5, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 5, 2021
Closed
@tirkarthi tirkarthi mentioned this pull request Oct 8, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 8, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 10, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 10, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Oct 11, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Oct 11, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 11, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Oct 26, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Oct 26, 2021
Closed
1 task
@tirkarthi tirkarthi mentioned this pull request Oct 27, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Oct 30, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Oct 30, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 2, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 2, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Nov 2, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Nov 5, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 5, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Nov 5, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Nov 5, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Nov 13, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 13, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 13, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Nov 13, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 16, 2021
Merged
@tirkarthi tirkarthi mentioned this pull request Nov 16, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 18, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Nov 26, 2021
Merged
9 tasks
@tirkarthi tirkarthi mentioned this pull request Dec 9, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Dec 22, 2021
Merged
4 tasks
@tirkarthi tirkarthi mentioned this pull request Dec 22, 2021
Merged
6 tasks
@tirkarthi tirkarthi mentioned this pull request Dec 22, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Dec 22, 2021
Closed
@tirkarthi tirkarthi mentioned this pull request Dec 22, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Dec 26, 2021
Open
@tirkarthi tirkarthi mentioned this pull request Jan 12, 2022
Open
gpshead added a commit to gpshead/cpython that referenced this issue Jan 26, 2022
@gpshead @gpshead
Revert "bpo-45162: Remove many old deprecated unittest features (pyth…
5c43e9c 
…onGH-28268)"

This reverts commit b0a6ede.

We're deferring this change until 3.12 while upstream projects that use
the legacy assertion method names are fixed.  See the issue for links
to the discussion.
gpshead added a commit that referenced this issue Jan 27, 2022
@gpshead @gpshead
bpo-45162: Revert "Remove many old deprecated unittest features" (GH-…
b50322d 
…30935)

Revert "bpo-45162: Remove many old deprecated unittest features (GH-28268)"

This reverts commit b0a6ede.

We're deferring this change until 3.12 while upstream projects that use
the legacy assertion method names are fixed.  See the issue for links
to the discussion. Many upstream projects now have issues and PRs
filed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambv ambv

Assignees
No one assigned
Labels
CLA signed type-enhancement
Projects
None yet
Milestone
No milestone
5 participants
@serhiy-storchaka @bedevere-bot @erlend-aasland @ambv @the-knights-who-say-ni