Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write #27271

Merged
merged 1 commit into from Jul 23, 2021
Merged

bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SSLSocket.write #27271

merged 1 commit into from Jul 23, 2021

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jul 20, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue42854
@pablogsal pablogsal requested a review from tiran Jul 20, 2021
tiran
tiran requested changes Jul 21, 2021
View changes
Copy link
Member

@tiran tiran left a comment

There are a bunch of warnings related to signed and unsigned comparison, e.g. comparison of integer expressions of different signedness: ‘size_t’ {aka ‘long unsigned int’} and ‘Py_ssize_t’ {aka ‘long int’} [-Wsign-compare]. Maybe use Py_ssize_t?

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 21, 2021

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@pablogsal pablogsal requested a review from tiran Jul 21, 2021
@pablogsal
Copy link
Member Author

@pablogsal pablogsal commented Jul 23, 2021 •
edited

I'm landing this as there is no compiler warnings anymore and I don't want to commit this very close to the rc.

@pablogsal pablogsal merged commit 83d1430 into python:main Jul 23, 2021
14 checks passed
@pablogsal pablogsal deleted the bpo-42854 branch Jul 23, 2021
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 23, 2021

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 23, 2021

GH-27308 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 23, 2021
@miss-islington
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SS…
f4f3f3c 
…LSocket.write (pythonGH-27271)

(cherry picked from commit 83d1430)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal pushed a commit that referenced this issue Jul 23, 2021
@miss-islington
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SS…
5ec2757 
…LSocket.write (GH-27271) (GH-27308)

(cherry picked from commit 83d1430)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@python python deleted a comment from bedevere-bot Jul 23, 2021
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@JuniorJPDJ
bpo-42854: Correctly use size_t for _ssl._SSLSocket.read and _ssl._SS…
8dbc9e7 
…LSocket.write (pythonGH-27271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
5 participants
@pablogsal @bedevere-bot @miss-islington @tiran @the-knights-who-say-ni