New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44558: Make the implementation consistency of operator.indexOf #27012

Merged

corona10 merged 2 commits into python:main from corona10:bpo-44558-index-of

Jul 5, 2021

Member

corona10 commented Jul 4, 2021 •

edited by bedevere-bot

https://bugs.python.org/issue44558

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting core review label

corona10 force-pushed the bpo-44558-index-of branch from af82eb3 to 776a54a

corona10 changed the title ~~bpo-44558: Make consistency of the implementation of operator.indexOf~~ bpo-44558: Make the implementation consistency of operator.indexOf


          bpo-44558: Make the implementation consistency of operator.indexOf

b9da2e2

corona10 force-pushed the bpo-44558-index-of branch from 776a54a to b9da2e2

corona10 added needs backport to 3.9 needs backport to 3.10 labels

corona10 requested a review from vstinner

Rupt mentioned this pull request

bpo-44558: Match countOf is/== treatment to c #27007

Merged

corona10 requested a review from serhiy-storchaka

serhiy-storchaka approved these changes

View changes

Lib/test/test_operator.py

  
                    nan = float("nan")

                    self.assertEqual(operator.indexOf([nan, nan, 21], nan), 0)

Member

serhiy-storchaka Jul 5, 2021

Would be nice to add a test for {} as in #27007.

bedevere-bot added awaiting merge and removed awaiting core review labels


          bpo-44558 Add test case

5e9690c

corona10 merged commit 0930240 into python:main

13 checks passed

bedevere-bot removed the awaiting merge label

Contributor

miss-islington commented Jul 5, 2021

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue


          bpo-44558: Make the implementation consistency of operator.indexOf (p…

7ddd0ec

…ythonGH-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>

bedevere-bot commented Jul 5, 2021

GH-27029 is a backport of this pull request to the 3.10 branch.

bedevere-bot removed the needs backport to 3.10 label

miss-islington added a commit to miss-islington/cpython that referenced this issue


          bpo-44558: Make the implementation consistency of operator.indexOf (p…

6dc40c4

…ythonGH-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>

bedevere-bot commented Jul 5, 2021

GH-27030 is a backport of this pull request to the 3.9 branch.

bedevere-bot removed the needs backport to 3.9 label

miss-islington added a commit that referenced this issue


          bpo-44558: Make the implementation consistency of operator.indexOf (G…

1f8486f

…H-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>

miss-islington added a commit that referenced this issue


          bpo-44558: Make the implementation consistency of operator.indexOf (G…

9f47d87

…H-27012)

(cherry picked from commit 0930240)

Co-authored-by: Dong-hee Na <donghee.na@python.org>

pablogsal mentioned this pull request

[3.10] Correct the order of regen-abidump #27228

Closed

JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue


          bpo-44558: Make the implementation consistency of operator.indexOf (p…

e6c1299

…ythonGH-27012)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment