Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44558: Match countOf is/== treatment to c #27007

Merged
merged 6 commits into from Jul 7, 2021
Merged

bpo-44558: Match countOf is/== treatment to c #27007

merged 6 commits into from Jul 7, 2021

Conversation

@Rupt
Copy link
Contributor

@Rupt Rupt commented Jul 3, 2021 •
edited

The python implementation and docstrings currently treat these comparisons differently.

This change preserves the existing behaviour of the c implementation.

Add tests for cases where is and == differ.

https://bugs.python.org/issue44558
bpo-44558: Match countOf is/== treatment to c
cc0694c 
Python impl and docstring treated these comparisons differently.
Update both docstrings to reflect the behavior.
This preserves the existing behaviour of the c implementation.
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Jul 3, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Rupt

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@Rupt
Copy link
Contributor Author

@Rupt Rupt commented Jul 3, 2021

Waiting "at least one business day" for CLA signing.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 4, 2021

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Rupt
Copy link
Contributor Author

@Rupt Rupt commented Jul 4, 2021

Replaced by #27012; closing.

@Rupt Rupt closed this Jul 4, 2021
@Rupt
Copy link
Contributor Author

@Rupt Rupt commented Jul 4, 2021

(oops - that is for indexOf - reopening)

@Rupt Rupt reopened this Jul 4, 2021
@Rupt @corona10
Update Misc/NEWS.d/next/Documentation/2021-07-03-18-25-17.bpo-44558.0…
44ccf3a 
…pTknl.rst

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
@Rupt @corona10
Update Misc/NEWS.d/next/Documentation/2021-07-03-18-25-17.bpo-44558.0…
0015da8 
…pTknl.rst

Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>
serhiy-storchaka
serhiy-storchaka approved these changes Jul 5, 2021
View changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

LGTM

@serhiy-storchaka serhiy-storchaka mentioned this pull request Jul 5, 2021
Merged
@Rupt
Copy link
Contributor Author

@Rupt Rupt commented Jul 5, 2021

I have made the requested changes; please review again

(apologies if this is noise, but the box still says there is a change requested)

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 5, 2021

Thanks for making the requested changes!

@corona10, @serhiy-storchaka: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from corona10 Jul 5, 2021
corona10
corona10 approved these changes Jul 5, 2021
View changes
Copy link
Member

@corona10 corona10 left a comment

lgtm I am waiting for CLA

@corona10 corona10 merged commit 6bd3ecf into python:main Jul 7, 2021
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 7, 2021

Thanks @Rupt for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jul 7, 2021

Sorry, @Rupt and @corona10, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6bd3ecfc272b122b55a6adec50dd7a7c868f262f 3.9

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 7, 2021

GH-27053 is a backport of this pull request to the 3.10 branch.

miss-islington added a commit to miss-islington/cpython that referenced this issue Jul 7, 2021
@Rupt @miss-islington
bpo-44558: Match countOf is/== treatment to c (pythonGH-27007)
2102ea0 
(cherry picked from commit 6bd3ecf)

Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>
miss-islington added a commit that referenced this issue Jul 7, 2021
@Rupt @miss-islington
bpo-44558: Match countOf is/== treatment to c (GH-27007)
9f431dd 
(cherry picked from commit 6bd3ecf)

Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>
@Rupt Rupt mentioned this pull request Jul 7, 2021
Closed
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jul 7, 2021

GH-27054 is a backport of this pull request to the 3.9 branch.

corona10 added a commit to corona10/cpython that referenced this issue Jul 7, 2021
@Rupt @corona10
[3.9] bpo-44558: Match countOf is/== treatment to c (pythonGH-27007…
3cf620f 
…).

(cherry picked from commit 6bd3ecf)

Co-authored-by: Rupert Tombs <rupert.tombs@gmail.com>
@Rupt
Copy link
Contributor Author

@Rupt Rupt commented Jul 7, 2021

Thank you for all the help @corona10 :-)

corona10 added a commit that referenced this issue Jul 7, 2021
@corona10
[3.9] bpo-44558: Match countOf is/== treatment to c (GH-27007). (G…
9761abf 
…H-27055)
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
JuniorJPDJ added a commit to JuniorJPDJ/cpython that referenced this issue Aug 12, 2021
@Rupt @JuniorJPDJ
bpo-44558: Match countOf is/== treatment to c (pythonGH-27007)
f8746cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

@vstinner vstinner

@serhiy-storchaka serhiy-storchaka

Assignees

@corona10 corona10

Labels
CLA signed
Projects
None yet
Milestone
No milestone
6 participants
@Rupt @the-knights-who-say-ni @bedevere-bot @miss-islington @serhiy-storchaka @corona10