Skip to content

Conversation

ajthr
Copy link
Contributor

@ajthr ajthr commented Jun 9, 2021

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you! One minor suggested tweak to the news entry.

Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
@ajthr ajthr requested a review from mdickinson June 9, 2021 16:52
@mdickinson
Copy link
Member

Still LGTM. Will merge as soon as the checks complete. Thank you, and congratulations on your first contribution to CPython! (I'll follow up on your other PR shortly.)

@ajthr
Copy link
Contributor Author

ajthr commented Jun 10, 2021

Still LGTM. Will merge as soon as the checks complete. Thank you, and congratulations on your first contribution to CPython! (I'll follow up on your other PR shortly.)

ty :)

@mdickinson mdickinson merged commit 90cd433 into python:main Jun 10, 2021
@bedevere-bot
Copy link

@mdickinson: Please replace # with GH- in the commit message next time. Thanks!

@ajthr ajthr deleted the issue44364 branch June 10, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants