python / cpython

Sponsor

Sponsor python/cpython
Notifications
Star 38.3k
Fork 19k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-44282: fix occasional test_incremental_editing failures on buildbots #26491

Merged

vstinner merged 1 commit into python:main from taleinat:bpo-44282/fix-test_incremental_editing

Jun 2, 2021

+49 −43

Contributor

taleinat commented Jun 2, 2021 •

edited by bedevere-bot

https://bugs.python.org/issue44282


            bpo-44282: fix occasional test_incremental_editing failures on buildbots

e49b2a5

Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>

taleinat added type-tests skip news needs backport to 3.10 labels

taleinat requested a review from terryjreedy as a code owner

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting core review label

taleinat requested a review from vstinner

taleinat added the 🔨 test-with-buildbots label

bedevere-bot commented Jun 2, 2021

🤖 New build scheduled with the buildbot fleet by @taleinat for commit e49b2a5 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots label

vstinner reviewed

Lib/idlelib/idle_test/test_colorizer.py

  
      @@ -551,7 +551,7 @@ def test_long_multiline_string(self):
    
                    ''')

                self._assert_highlighting(source, {'STRING': [('1.0', '5.4')]})

            @run_in_tk_mainloop

            @run_in_tk_mainloop(delay=50)

vstinner Jun 2, 2021
Member

What is this magic number? A number of seconds?

I suggest you to use test.support.SHORT_TIMEOUT or test.support.LONG_TIMEOUT: https://docs.python.org/dev/library/test.html#test.support.SHORT_TIMEOUT

taleinat Jun 2, 2021
Author Contributor

What is this magic number? A number of seconds?

Milliseconds. It's explained in the decorator's doc-string.

I suggest you to use test.support.SHORT_TIMEOUT or test.support.LONG_TIMEOUT

I wasn't aware of these, good to know! I don't think they're quite what's needed here though.

taleinat Jun 2, 2021
Author Contributor

What is this magic number? A number of seconds?

Milliseconds. It's explained in the decorator's doc-string.

Would you prefer that this was a datetime.timedelta instance?

vstinner Jun 2, 2021
Member

No, it's fine.

vstinner approved these changes

Member

vstinner left a comment •

edited

LGTM. Well, I don't understand how Tkinter handles time, so let's see if 50 ms is enough for everyone :-p

bedevere-bot added awaiting merge and removed awaiting core review labels

terryjreedy approved these changes

Member

terryjreedy left a comment •

edited

Exactly what I meant as an alternative to skipping. While the latter would be okay for this test, we may have other tests where a much smaller delay, even 2 or 3 is sufficient.

vstinner merged commit adef445 into python:main

11 checks passed

11 checks passed

Check for source changes

Details

Check if generated files are up to date

Details

Windows (x86)

Details

Windows (x64)

Details

macOS

Details

Ubuntu

Details

Ubuntu SSL tests with OpenSSL

Details

Azure Pipelines PR #20210602.28 succeeded

Details

Travis CI - Pull Request Build Passed

Details

bedevere/issue-number Issue number 44282 found

Details

bedevere/news "skip news" label found

bedevere-bot removed the awaiting merge label

Contributor

miss-islington commented Jun 2, 2021

Thanks @taleinat for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request


            bpo-44282: Fix occasional test_incremental_editing failures on buildb…

8be62bf

…ots (pythonGH-26491)

Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>
(cherry picked from commit adef445)

Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>

bedevere-bot removed the needs backport to 3.10 label

bedevere-bot commented Jun 2, 2021

GH-26499 is a backport of this pull request to the 3.10 branch.

Member

vstinner commented Jun 2, 2021

I merge the issue right now since it broke buildbots and I'm trying to recover the green color of buildbots!

Member

terryjreedy commented Jun 3, 2021

A note to myself: Backport the revised tkinter helper file to 3.9 so we can use it with future tests that get backported to 3.9.

vstinner pushed a commit that referenced this pull request


            bpo-44282: Fix occasional test_incremental_editing failures on buildb…

9c89d62

…ots (GH-26491) (GH-26499)

Signed-off-by: Tal Einat <532281+taleinat@users.noreply.github.com>
(cherry picked from commit adef445)

Co-authored-by: Tal Einat <532281+taleinat@users.noreply.github.com>

Contributor Author

taleinat commented Jun 3, 2021 •

edited

A note to myself: Backport the revised tkinter helper file to 3.9 so we can use it with future tests that get backported to 3.9.

Note that the helper is currently missing on the 3.9 branch, as it was added as part of the PR which added the shell sidebar, which we haven't backported to 3.9. We'd likely want to backport that PR to 3.9 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment