Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29418: Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given #19261

Merged
merged 18 commits into from Feb 16, 2022
Merged

bpo-29418: Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given #19261

merged 18 commits into from Feb 16, 2022
+63 −12

Conversation

@hakancelik96
Copy link
Contributor

@hakancelik96 hakancelik96 commented Mar 31, 2020 •
edited by miss-islington

https://bugs.python.org/issue29418

Automerge-Triggered-By: GH:isidentical
@hakancelik96 hakancelik96 changed the title bpo-29418: Fix this issue, add new function named ismethodwrapper and more test write to isroutine function of inspect module bpo-29418: Fix this issue, add new function named ismethodwrapper. Mar 31, 2020
@hakancelik96 hakancelik96 changed the title bpo-29418: Fix this issue, add new function named ismethodwrapper. bpo-29418: Fix, return True if the object is a method-wrapper add new function named ismethodwrapper Mar 31, 2020
@isidentical isidentical requested a review from 1st1 Apr 16, 2020
@hakancelik96 hakancelik96 changed the title bpo-29418: Fix, return True if the object is a method-wrapper add new function named ismethodwrapper Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given Apr 17, 2020
@hakancelik96 hakancelik96 changed the title Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given bpo-29418: Implement inspect.ismethodwrapper and fix inspect.isroutine for cases where methodwrapper is given Apr 17, 2020
taleinat
taleinat requested changes Sep 26, 2020
View changes
Copy link
Contributor

@taleinat taleinat left a comment

This looks very good! I only have a few minor requests.

Doc/whatsnew/3.9.rst Outdated Show resolved Hide resolved
Doc/library/inspect.rst Outdated Show resolved Hide resolved
Lib/inspect.py Outdated Show resolved Hide resolved
Lib/test/test_inspect.py Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 26, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hakancelik96 hakancelik96 force-pushed the bpo-29418 branch 3 times, most recently from 338a0fd to ff914e0 Sep 27, 2020
@hakancelik96 hakancelik96 requested a review from taleinat Sep 27, 2020
@hakancelik96
Copy link
Contributor Author

@hakancelik96 hakancelik96 commented Sep 27, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 27, 2020

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

taleinat
taleinat reviewed Sep 28, 2020
View changes
Copy link
Contributor

@taleinat taleinat left a comment

Looks very good! A couple of small suggestions.

Lib/inspect.py Outdated Show resolved Hide resolved
Lib/test/test_inspect.py Outdated Show resolved Hide resolved
@hakancelik96
Copy link
Contributor Author

@hakancelik96 hakancelik96 commented Sep 29, 2020

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Sep 29, 2020

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from taleinat Sep 29, 2020
@hakancelik96
Copy link
Contributor Author

@hakancelik96 hakancelik96 commented Feb 13, 2022

I have made the requested changes; please review again

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 13, 2022

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

isidentical
isidentical approved these changes Feb 15, 2022
View changes
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Lib/inspect.py Outdated Show resolved Hide resolved
hakancelik96 and others added 2 commits Feb 15, 2022
@hakancelik96 @isidentical
Update Doc/whatsnew/3.10.rst
d7e2f16 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
@hakancelik96 @isidentical
Update Lib/inspect.py
fd03838 
Co-authored-by: Batuhan Taskaya <isidentical@gmail.com>
asvetlov
asvetlov reviewed Feb 16, 2022
View changes
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
asvetlov
asvetlov reviewed Feb 16, 2022
View changes
Doc/whatsnew/3.10.rst Outdated Show resolved Hide resolved
asvetlov
asvetlov approved these changes Feb 16, 2022
View changes
Copy link
Contributor

@asvetlov asvetlov left a comment

LGTM

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 16, 2022

@hakancelik96: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Feb 16, 2022

@hakancelik96: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 562c13f into python:main Feb 16, 2022
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@isidentical isidentical

@1st1 1st1

@taleinat taleinat

Assignees
No one assigned
Labels
CLA signed 🤖 automerge
Projects
None yet
Milestone
No milestone
7 participants
@hakancelik96 @bedevere-bot @miss-islington @asvetlov @taleinat @isidentical @the-knights-who-say-ni