bpo-39912: Raise appropriate exceptions in filterwarnings() and simplefilter() #18878
+42
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
reviewed
Mar 12, 2020
| "once"), "invalid action: %r" % (action,) | ||
| assert isinstance(lineno, int) and lineno >= 0, \ | ||
| "lineno must be an int >= 0" | ||
| if action not in ("error", "ignore", "always", "default", "module", "once"): |
There was a problem hiding this comment.
What about the category argument?
Also it may be worth to move the duplicated code into a subfunction.
There was a problem hiding this comment.
The category argument is a bit different, it's supposed to be a subclass of Warning and nothing else but in some cases like https://github.com/python/cpython/blob/master/Lib/unittest/test/test_case.py#L1435 it will get called with a tuple.
Should we relax the condition on category so it accepts tuples of Warning subclasses too or fix unittest so it calls simplefilter() multiple time when given a iterable?
Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue39912
https://bugs.python.org/issue16845
https://bugs.python.org/issue21865