Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43822: When reporting parser custom errors, check first for tokenizer errors #25866

Merged
merged 1 commit into from May 4, 2021
Merged

bpo-43822: When reporting parser custom errors, check first for tokenizer errors #25866

merged 1 commit into from May 4, 2021

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented May 3, 2021 •
edited by bedevere-bot

@pablogsal pablogsal requested a review from lysnikolaou as a code owner May 3, 2021
@pablogsal pablogsal merged commit 9142088 into python:main May 4, 2021
11 of 12 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 4, 2021

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@pablogsal pablogsal deleted the pegen_tokenizer branch May 4, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
@pablogsal @miss-islington
bpo-43822: Prioritize tokenizer errors over custom syntax errors when…
9239f69 
… raising parser exceptions (pythonGH-25866)

(cherry picked from commit 9142088)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented May 4, 2021

GH-25869 is a backport of this pull request to the 3.10 branch.

@miss-islington
Copy link
Contributor

miss-islington commented May 4, 2021

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

bedevere-bot commented May 4, 2021

GH-25870 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 4, 2021
@pablogsal @miss-islington
bpo-43822: Prioritize tokenizer errors over custom syntax errors when…
e813285 
… raising parser exceptions (pythonGH-25866)

(cherry picked from commit 9142088)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request May 4, 2021
@miss-islington @pablogsal
bpo-43822: Prioritize tokenizer errors over custom syntax errors when…
756b7b9 
… raising parser exceptions (GH-25866)

(cherry picked from commit 9142088)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
miss-islington added a commit that referenced this pull request May 4, 2021
@miss-islington @pablogsal
bpo-43822: Prioritize tokenizer errors over custom syntax errors when…
d1ff838 
… raising parser exceptions (GH-25866)

(cherry picked from commit 9142088)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni