Skip to content

bpo-43815: Fixing doc for callback for lambda #25779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2021
Merged

bpo-43815: Fixing doc for callback for lambda #25779

merged 1 commit into from
May 1, 2021
+1 −1

Conversation

shreyneil
Copy link

@shreyneil shreyneil commented May 1, 2021 •
edited by miss-islington
Loading

Fixing callback for lambda when no return value is provided

https://bugs.python.org/issue43815

Automerge-Triggered-By: GH:ericvsmith

@shreyneil
Fixing doc for callback for lambda
d255ecf 
Fixing callback for lambda when no return value is provided
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label May 1, 2021
@shreyneil
Copy link
Author

@ericvsmith have made changes as per your suggestion, it would be great if you can review.

ericvsmith
ericvsmith approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@miss-islington
Copy link
Contributor

@shreyneil: Status check is done, and it's a success ❌ .

@ericvsmith
Copy link
Member

The failing tests are unrelated. This is a documentation change.

@shreyneil
Copy link
Author

The failing tests are unrelated. This is a documentation change.

@ericvsmith can we go ahead with the merge then ?

@ericvsmith
Copy link
Member

I'd like to, but the UI won't let me. I'll see if closing it and reopening it can re-run the tests and have them succeed.

@ericvsmith ericvsmith closed this May 1, 2021
@ericvsmith ericvsmith reopened this May 1, 2021
@miss-islington
Copy link
Contributor

@shreyneil: Status check is done, and it's a success ❌ .

1 similar comment
@miss-islington
Copy link
Contributor

@shreyneil: Status check is done, and it's a success ❌ .

@ericvsmith ericvsmith self-assigned this May 1, 2021
@ericvsmith
Copy link
Member

You have to love this message:

Status check is done, and it's a success ❌ .

I'm not sure the red X tells me it's a success!

@ericvsmith
Copy link
Member

Now it's letting me commit. Thanks for the fix, @shreyneil.

@ericvsmith ericvsmith merged commit 50c21ad into python:master May 1, 2021
@miss-islington
Copy link
Contributor

Thanks @shreyneil for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-25789 is a backport of this pull request to the 3.8 branch.

ericvsmith pushed a commit that referenced this pull request May 1, 2021
@miss-islington
Fixing doc for callback for lambda (GH-25779) (GH-25789)
3519ac4 
Fixing callback for lambda when no return value is provided
(cherry picked from commit 50c21ad)

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>

Co-authored-by: Shreyash Sharma <shreyash.sharma@philips.com>
@ericvsmith ericvsmith removed the needs backport to 3.9 only security fixes label May 1, 2021
@ericvsmith ericvsmith added the needs backport to 3.9 only security fixes label May 1, 2021
@miss-islington
Copy link
Contributor

Thanks @shreyneil for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@ericvsmith ericvsmith added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels May 1, 2021
@miss-islington
Copy link
Contributor

Thanks @shreyneil for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@ericvsmith
Copy link
Member

I can't get miss-islington to trigger the actual backport to 3.9. I guess I'll just have to be more patient.

@shreyneil shreyneil deleted the patch-2 branch May 1, 2021 19:06
@shreyneil
Copy link
Author

shreyneil commented May 1, 2021 •
edited
Loading

I can't get miss-islington to trigger the actual backport to 3.9. I guess I'll just have to be more patient.

@ericvsmith correct have to be patient, try to get miss-islington to trigger the backport to 3.9.

@Mariatta Mariatta added needs backport to 3.9 only security fixes and removed needs backport to 3.9 only security fixes labels May 1, 2021
@miss-islington
Copy link
Contributor

Thanks @shreyneil for the PR, and @ericvsmith for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@Mariatta Mariatta removed the needs backport to 3.9 only security fixes label May 1, 2021
@Mariatta
Copy link
Member

Mariatta commented May 1, 2021

I'm looking into it.

@Mariatta
Copy link
Member

Mariatta commented May 1, 2021

The PR was already created at #25788

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

Assignees

@ericvsmith ericvsmith

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shreyneil @miss-islington @ericvsmith @bedevere-bot @Mariatta @the-knights-who-say-ni