bpo-28254: Add PyGC_ functions to the stable ABI manifest #25720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orsenthil
reviewed
Apr 29, 2021
| @@ -2142,3 +2142,9 @@ const Py_am_send | |||
| # (Detailed comments aren't really needed for further entries: from here on | |||
| # we can use version control logs.) | |||
|
|
|||
| function PyGC_Disable | |||
There was a problem hiding this comment.
Looks good to me.
Shouldn't these at line 2124.
orsenthil
approved these changes
Apr 29, 2021
scoder
reviewed
Apr 29, 2021
pablogsal
approved these changes
Apr 29, 2021
scoder
approved these changes
Apr 29, 2021
Co-authored-by: scoder <stefan_ml@behnel.de>
kreathon
pushed a commit
to kreathon/cpython
that referenced
this pull request
May 2, 2021
…5720) Co-authored-by: Senthil Kumaran <senthil@uthcode.com> Co-authored-by: scoder <stefan_ml@behnel.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I've just merged the "stable ABI manifest" part of PEP-652, so checks fail since 3 new functions were added to the stable ABI.
Misc/stable_abi.txtmake regen-limited-abi)https://bugs.python.org/issue28254