Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43960: reset global breakpoint state at the beginning of a pdb te… #25673

Merged
merged 1 commit into from Apr 28, 2021
Merged

bpo-43960: reset global breakpoint state at the beginning of a pdb te… #25673

merged 1 commit into from Apr 28, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 27, 2021 •
edited by bedevere-bot

…st to make it deterministic

https://bugs.python.org/issue43960

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 27, 2021
@iritkatriel iritkatriel requested a review from vstinner Apr 27, 2021
@vstinner vstinner merged commit 21b02b5 into python:master Apr 28, 2021
11 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2021

Thanks @iritkatriel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2021

Thanks @iritkatriel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2021

Sorry @iritkatriel and @vstinner, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 21b02b5f4018474620676be04310f7d230a464ea 3.8

@bedevere-bot
Copy link

bedevere-bot commented Apr 28, 2021

GH-25681 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 28, 2021
@iritkatriel @miss-islington
bpo-43960: test_pdb resets breakpoints (pythonGH-25673)
9e99acc 
Reset global breakpoint state at the beginning of
test_pdb_next_command_in_generator_for_loop() to make it deterministic.
(cherry picked from commit 21b02b5)

Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2021

Thanks @iritkatriel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Apr 28, 2021

GH-25682 is a backport of this pull request to the 3.8 branch.

@vstinner
Copy link
Member

vstinner commented Apr 28, 2021

Oh, thanks for the fix @iritkatriel, it fix my issue and it LGTM. I merged your fix and backported it to 3.8 and 3.9.

kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@iritkatriel @kreathon
bpo-43960: test_pdb resets breakpoints (pythonGH-25673)
5a3a309 
Reset global breakpoint state at the beginning of
test_pdb_next_command_in_generator_for_loop() to make it deterministic.
@iritkatriel iritkatriel deleted the bpo-43960 branch May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner

Assignees

@vstinner vstinner

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@iritkatriel @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni