bpo-43893: omit leading spaces/tabs on typing.get_type_hints#25484
Closed
JarryShaw wants to merge 2 commits intopython:mainfrom
Closed
bpo-43893: omit leading spaces/tabs on typing.get_type_hints#25484JarryShaw wants to merge 2 commits intopython:mainfrom
JarryShaw wants to merge 2 commits intopython:mainfrom
Conversation
Fidget-Spinner
approved these changes
Apr 20, 2021
Member
There was a problem hiding this comment.
Excellent work! I don't have an opinion on whether this should be a feature (after all, I don't really have a problem with leaving leading whitespace in my string annotations). But let's see what the others has to say on the bug tracker :). Otherwise, from a technical point of view, everything looks good. Thank you!
bateller
approved these changes
Apr 20, 2021
Contributor
nanjekyejoannah
left a comment
There was a problem hiding this comment.
There seems to not be a consensus yet judging from the bpo discussion.
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
Sorry, I think this is not worth fixing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43893