Update Condition class #25526
Update Condition class #25526
Conversation
The `loop` parameter will be removed in version 3.10. As far as I can see, `loop` parameter is still present in source code, but it is initialized to special value `mixin._marker`. It is still in source code probably for backward compatibility reasons. If this is true, we should be able to check if `lock._loop is not None`, and then check if it matches with `self._loop()`. I run into this issue with 3rd party library `aetcd3` which does not explicitly check loop of its `asyncio.Lock/Condition` instances, but `asyncio.locks.Condition` does not correctly check for this condition. After monkey-patching `asyncio.Condition`, everything works as expected.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Sure, thanks! |
The
loopparameter will be removed in version 3.10. As far as I can see,loopparameter is still present in source code, but it is initialized to special valuemixin._marker. It is still in source code probably for backward compatibility reasons. If this is true, we should be able to check iflock._loop is not None, and then check if it matches withself._loop().I run into this issue with 3rd party library
aetcd3which does not explicitly check loop of itsasyncio.Lock/Conditioninstances, butasyncio.locks.Conditiondoes not correctly check for this condition. After monkey-patchingasyncio.Condition, everything works as expected.