Mod : Example 16-17 grouper optimization #5
Conversation
|
@ramalho i think the example should be this. currently, a new delegating generator is created for each item in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
The delegating generator grouper delegates averager inside a while loop.
Every time averager returns, a new but useless averager instance will be created during the following loop period.
Adding a
yieldstatement afteryield from averager()without while loop would be better.Great great book, by the way.