Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified Vector v4 equality check #35

Open
wants to merge 1 commit into
base: master
from

Conversation

@adnanmuttaleb
Copy link

@adnanmuttaleb adnanmuttaleb commented Oct 29, 2019

According to my understanding of hashing and equality, I tried to enhance the performance of equality checking by ensuring that __eq__ does not perform component based comparison only if vectors has the same hash values (if two hashes is different then the two vectors are definitely unequal). because if two vectors has same hash value then:

  •    either they equal 
    
  •    they are not equal `Vector(1, 0, -1)`  and  `Vector(1, -1, 0)` will have the same hash value of -2
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.