Move some database commands to overflow menu #708
Conversation
9c78823 to
26aae1b
Compare
| { | ||
| "command": "codeQLDatabases.chooseDatabaseInternet", | ||
| "title": "Download Database", | ||
| "title": "Add Database from Internet", |
There was a problem hiding this comment.
"from URL" is another option.
| "command": "codeQLDatabases.chooseDatabaseFolder", | ||
| "when": "view == codeQLDatabases", | ||
| "group": "navigation" | ||
| "group": "1_open@1" |
There was a problem hiding this comment.
Is it possible to create your own group below an icon, rather than the overflow menu? I think decluttering the database view is a good idea, but I am concerned users will not know to look in the overflow menu for 'Add Database' commands, whereas an 'Add Database From...' submenu may be more obvious.
There was a problem hiding this comment.
I don't know if that's possible. Let me look.
There was a problem hiding this comment.
No. It's not. https://code.visualstudio.com/api/extension-guides/tree-view#view-actions
I could put the actions in both places, but that seems worse. I feel like I would want to talk to a UX engineer for this.
This commit moves the "Add *" and "Download *" database commands from the buttons on top and into an overflow menu. I believe this is easier to read since the icons were never fully understandable and required hovering to read. Also, renamed the commands to be more consistent. Now all begin with "Add Database from".
26aae1b to
e48d8bb
Compare
|
It does declutter a bit, but it seems a lot less discoverable than before... |
|
As a user of the extension, I prefer the existing behaviour. I've only ever used two of those buttons, but I've used them a lot: Add Database from {Archive, Folder}. |
|
No consensus on this. Not going to go ahead with this change. |
This commit moves the "Add *" and "Download *" database commands
from the buttons on top and into an overflow menu.
I believe this is easier to read since the icons were never fully
understandable and required hovering to read.
Also, renamed the commands to be more consistent. Now all begin
with "Add Database from".
Simple PR to change the layout of the view commands. I didn't know this was possible until I saw it in another extension. Will look like this:
I'm open to better wording than "Download Database from Internet".
Checklist
@github/docs-content-dsphas been cc'd in all issues for UI or other user-facing changes made by this pull request.