Skip to content

/ VisualStudio

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try really hard to avoid deadlocking GetService calls #1597

Closed
wants to merge 2 commits into from
Closed

Try really hard to avoid deadlocking GetService calls #1597

wants to merge 2 commits into from

Commits on Apr 12, 2018

  1. Try really hard to avoid deadlocking GetService calls 

    `new ShellSettingsManager` in the PackageSettings constructor
calls GetService, which might be a potential deadlock situation.
Also, to avoid calls to GetService that might deadlock, cache
the services we create in GitHubServiceProvider so that it returns
cached instances immediately and bypasses GetService.
    @shana
    shana committed Apr 12, 2018
    Loading status checks…
    a23ff51

Commits on Apr 13, 2018

  1. Move to async GetService calls everywhere and split mef from non-mef

    @shana
    shana committed Apr 13, 2018
    Loading status checks…
    8b8ecc0
You can’t perform that action at this time.