Skip to content

Docs: add an example .qls with a tag regex#4793

Open
rdmarsh2 wants to merge 1 commit into
github:mainfrom
rdmarsh2:rdmarsh2/docs/qlpack-tag-regex-example
Open

Docs: add an example .qls with a tag regex#4793
rdmarsh2 wants to merge 1 commit into
github:mainfrom
rdmarsh2:rdmarsh2/docs/qlpack-tag-regex-example

Conversation

@rdmarsh2
Copy link
Copy Markdown
Contributor

@rdmarsh2 rdmarsh2 commented Dec 7, 2020

No description provided.

@rdmarsh2 rdmarsh2 requested a review from a team December 7, 2020 21:00
- qlpack: codeql-javascript
- include:
kind: problem
tags contain: /^external\/cwe\//
Copy link
Copy Markdown
Contributor

@hmakholm hmakholm Dec 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tags contain: /^external\/cwe\//
tags contain: /^external\/cwe/

Either there shouldn't be a trailing escaped slash here, or it should be mentioned in the description of what the example does.

@shati-patel
Copy link
Copy Markdown
Contributor

👋🏽 @rdmarsh2, just spotted this in passing! Is it still worth adding/fixing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants