Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
added warning if mutable rev is used #1715
Open
+63
−0
Conversation
2773384
to
1a2b4a0
| def check(self, dct: Dict[str, Any]) -> None: | ||
| if any( | ||
| mutable in dct.get(self.key, '') | ||
| for mutable in {'HEAD', 'stable', 'master'} |
asottile
Nov 26, 2020
Member
I'm not sure this will catch all the cases, notably it's missing '', 'main' at the very least
I wonder if there's an easier way to catch these -- maybe match anything that doesn't look like a version?
I'm not sure this will catch all the cases, notably it's missing '', 'main' at the very least
I wonder if there's an easier way to catch these -- maybe match anything that doesn't look like a version?
paulhfischer
Nov 26, 2020
•
Author
Contributor
alternative idea (not added yet, wanted to hear your feedback first):
rev = dct.get(self.key, "")
if (
"." not in rev and ( # not a version
len(rev) != 40 or # full sha
len(rev) != 7 or # short sha
len(rev) != 8 or # gitlab lists 8 char long sha in the commit-list
) or
not re.match(r"^[a-zA-Z0-9]+$", rev) # contains other chars (e.g. "_", "-", …)
)
# print warning
alternative idea (not added yet, wanted to hear your feedback first):
rev = dct.get(self.key, "")
if (
"." not in rev and ( # not a version
len(rev) != 40 or # full sha
len(rev) != 7 or # short sha
len(rev) != 8 or # gitlab lists 8 char long sha in the commit-list
) or
not re.match(r"^[a-zA-Z0-9]+$", rev) # contains other chars (e.g. "_", "-", …)
)
# print warning1a2b4a0
to
caa8451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
resolves #974
MigrateShaToRev-class, but i think it's better to keep them separatedHEAD, this is sufficient imo, but i can also change it so it tests for all mutable revs defined in{'HEAD', 'stable', 'master'}