Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check cygwin mismatch earlier #1606

Merged
merged 1 commit into from Sep 20, 2020
Merged

check cygwin mismatch earlier #1606

merged 1 commit into from Sep 20, 2020

Conversation

@asottile
Copy link
Member

@asottile asottile commented Sep 20, 2020

resolves #1605

@danyeaw
Copy link

@danyeaw danyeaw commented Sep 20, 2020

@asottile I tried this out, and it does move the cygwin mismatch check up earlier. I don't think it fixes the issue though, it isn't that I am missing the error because of the other issues, the problem is that I shouldn't be getting this warning at all. I am not running in cygwin, I am in MSYS2 and my git and Python aren't mismatched.

@asottile
Copy link
Member Author

@asottile asottile commented Sep 20, 2020

they are mismatched, one is acting like windows and the other is acting like posix -- that's the entire point of the warning

@asottile asottile force-pushed the move_cygwin_mismatch branch from c87d534 to 91530f1 Sep 20, 2020
@asottile asottile merged commit f13dcac into master Sep 20, 2020
1 check passed
1 check passed
pre-commit.pre-commit #20200920.3 succeeded
Details
@asottile asottile deleted the move_cygwin_mismatch branch Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.