Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python_2_eol.html template uses vulnerable moment version #1832

Open
KieranCairney opened this issue Dec 11, 2019 · 1 comment
Open

python_2_eol.html template uses vulnerable moment version #1832

KieranCairney opened this issue Dec 11, 2019 · 1 comment

Comments

@KieranCairney
Copy link

@KieranCairney KieranCairney commented Dec 11, 2019

I'm submitting a ...

  • bug report
  • feature request
  • question about the decisions made in the repository

Do you want to request a feature or report a bug?

Reporting a Bug

What is the current behavior?

python_2_eol.html template uses vulnerable moment version (v2.18.1 moment.js is vulnerable to regular expression denial of service via a crafted date string)

If the current behavior is a bug, please provide the steps to reproduce and if possible a screenshots and logs of the problem. If you can, show us your code.

See: https://github.com/cherrypy/cherrypy/blob/1980247/docs/_templates/python_2_eol.html#L78

What is the expected behavior?

Upgrade moment version to a new version (ie. 2.22.2)

What is the motivation / use case for changing the behavior?

v2.18.1 of moment.js is vulnerable to regular expression denial of service via a crafted date string

Please tell us about your environment:

Not required

Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, e.g. stackoverflow, gitter, etc.)

Not required

@triage-new-issues triage-new-issues bot added the triage label Dec 11, 2019
@webknjaz
Copy link
Member

@webknjaz webknjaz commented Dec 21, 2019

I don't think this affects us because the use is pretty match hardcoded... But feel free to send a PR upgrading moment.js!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.