neg: Should use class(self)(...) instead of Vector(...) #1

Grazfather · 2017-01-31T04:20:31Z

In your solution to vector you use Vector:

    def __neg__(self):
        return Vector(-x for x in self)

You also hardcode Vector in __add__.

Above it, though, in __getitem__ you get the class by using class(self). This seems inconsistent, and probably incorrect. If you were to subclass Vector, for instance, it would break when negating an instance of the subclass.

fluentpython / pythonic-api

neg: Should use class(self)(...) instead of Vector(...) #1

neg: Should use class(self)(...) instead of Vector(...) #1

Grazfather commented Jan 31, 2017 •

edited

fluentpython / pythonic-api

Join GitHub today

GitHub is where the world builds software

__neg__: Should use class(self)(...) instead of Vector(...) #1

__neg__: Should use class(self)(...) instead of Vector(...) #1

Comments

Grazfather commented Jan 31, 2017 • edited

Essential cookies

Always active

Analytics cookies

neg: Should use class(self)(...) instead of Vector(...) #1

neg: Should use class(self)(...) instead of Vector(...) #1

Grazfather commented Jan 31, 2017 •

edited